From c1eb7075198ba91a73427f60bfc82ac974b3140d Mon Sep 17 00:00:00 2001 From: Mike Geppert Date: Wed, 7 Jan 2026 19:57:47 -0600 Subject: [PATCH] Revert "Add delays and retry logic for SetOption verification" This reverts commit 794eb4319be7c910fc966a26bceba130bbd75418. --- console_settings.py | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/console_settings.py b/console_settings.py index 063561b..8f2b6a1 100644 --- a/console_settings.py +++ b/console_settings.py @@ -179,22 +179,12 @@ class ConsoleSettingsManager: if not success: self.logger.error(f"{device_name}: Failed to set {param_name} after 3 attempts") return False - - # Wait for device to process the command before verifying - time.sleep(0.5) - + # Verify the command was applied (if possible) - verified = self._verify_command(device_ip, device_name, param_name, param_value) - - if not verified: - # Wait a bit longer and try verification again - time.sleep(0.5) - verified = self._verify_command(device_ip, device_name, param_name, param_value) - - if not verified: - self.logger.warning(f"{device_name}: Verification failed for {param_name}") - # Don't return False here - some commands can't be verified - + if not self._verify_command(device_ip, device_name, param_name, param_value): + self.logger.warning(f"{device_name}: Verification failed for {param_name}") + # Don't return False here - some commands can't be verified + # Check if this is a rule definition - if so, enable it if param_name.lower().startswith('rule'): rule_number = param_name.lower().replace('rule', '') @@ -212,10 +202,8 @@ class ConsoleSettingsManager: if not success: self.logger.warning(f"{device_name}: Failed to enable rule{rule_number}") - - time.sleep(0.5) # Wait after enabling rule - - time.sleep(0.5) # Delay between commands to avoid overwhelming device + + time.sleep(0.3) # Brief delay between commands return True def _verify_command(self, device_ip: str, device_name: str,