mgeppert/TasmotaManager
mgeppert/TasmotaManager
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Add delays and retry logic for SetOption verification"

Browse Source 
This reverts commit 794eb4319b.
This commit is contained in:
Mike Geppert 2026-01-07 19:57:47 -06:00
parent 794eb4319b
commit c1eb707519
1 changed files with 7 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
console_settings.py
View File

@ -179,22 +179,12 @@ class ConsoleSettingsManager:
if not success: if not success:
self.logger.error(f"{device_name}: Failed to set {param_name} after 3 attempts") self.logger.error(f"{device_name}: Failed to set {param_name} after 3 attempts")
return False return False
# Wait for device to process the command before verifying
time.sleep(0.5)
# Verify the command was applied (if possible) # Verify the command was applied (if possible)
verified = self._verify_command(device_ip, device_name, param_name, param_value) if not self._verify_command(device_ip, device_name, param_name, param_value):
self.logger.warning(f"{device_name}: Verification failed for {param_name}")
if not verified: # Don't return False here - some commands can't be verified
# Wait a bit longer and try verification again
time.sleep(0.5)
verified = self._verify_command(device_ip, device_name, param_name, param_value)
if not verified:
self.logger.warning(f"{device_name}: Verification failed for {param_name}")
# Don't return False here - some commands can't be verified
# Check if this is a rule definition - if so, enable it # Check if this is a rule definition - if so, enable it
if param_name.lower().startswith('rule'): if param_name.lower().startswith('rule'):
rule_number = param_name.lower().replace('rule', '') rule_number = param_name.lower().replace('rule', '')
@ -212,10 +202,8 @@ class ConsoleSettingsManager:
if not success: if not success:
self.logger.warning(f"{device_name}: Failed to enable rule{rule_number}") self.logger.warning(f"{device_name}: Failed to enable rule{rule_number}")
time.sleep(0.5) # Wait after enabling rule time.sleep(0.3) # Brief delay between commands
time.sleep(0.5) # Delay between commands to avoid overwhelming device
return True return True
def _verify_command(self, device_ip: str, device_name: str, def _verify_command(self, device_ip: str, device_name: str,